role: hosted_engine_setup: Filter devices with unsupported bond mode

[aviv92]

Filter VLAN devices with bond parent configured with unsupported bond mode

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1585462
Signed-off-by: Aviv Turgeman [email protected]

[ovirt-infra]

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

1. Type ci test please on this PR to trigger automated tests for it.
2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow ovirt dynamic plugin improvements #3 option )
3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

[avivtur]

Verified

[mwperina]

ci add to whitelist

[mwperina]

@almusil

[mwperina]

If this is a fix for https://bugzilla.redhat.com/show_bug.cgi?id=1585462, could you please add this PR to the bug? Unlike in gerrit.ovirt.org there is no automation to add patches to relevant bugzilla bug

@aviv92

[avivtur]

If this is a fix for https://bugzilla.redhat.com/show_bug.cgi?id=1585462, could you please add this PR to the bug? Unlike in gerrit.ovirt.org there is no automation to add patches to relevant bugzilla bug

Sure thanks for letting me know

@mnecas Can you please review?

[almusil]

So I am not really fluent in ansible, but it seems ok. As for the wording, it is actually the other way around VLAN is parent/master of the bond, the bond in this relation is called base interface. I guess it's not a blocker for the code maybe it would be nice to change it in fact names.

[avivtur]

So I am not really fluent in ansible, but it seems ok. As for the wording, it is actually the other way around VLAN is parent/master of the bond, the bond in this relation is called base interface. I guess it's not a blocker for the code maybe it would be nice to change it in fact names.

Thanks for notice that, you're absolutly right, I hope this will make things more clear

[arachmani]

The message is not clear, maybe change it to something like:
Only unsupported devices {{ invalid_net_if | join(', ') }} are present.
Teaming and bond modes: Round Robin, TLB, ALB are unsupported.
The following bond modes are supported: {{ acceptable_bond_modes }}

Please create a variable for the supported bond list and use it also in filter_unsupported_vlan_devices.yml

[avivtur]

Verified