ovirt_disk: fix vm names search and allow attaching to vm (#361)

* ovirt_disk: fix vm_names search when attaching to vm

* fix force_create to allow attaching vm

* add changelogs

changelogs/fragments/361-ovirt_disk-fix-disk-attachment.yml

@@ -0,0 +1,3 @@
+---
+minor_changes:
+  - ovirt_disk - Fix disk attachment to VM (https://github.com/oVirt/ovirt-ansible-collection/pull/361).

plugins/modules/ovirt_disk.py

@@ -767,7 +767,7 @@ def searchable_attributes(module):
     attributes = {
         'name': module.params.get('name'),
         'Storage.name': module.params.get('storage_domain'),
-        'vm_names': module.params.get('vm_name'),
+        'vm_names': module.params.get('vm_name') if module.params.get('state') != 'attached' else None,
     }
     return dict((k, v) for k, v in attributes.items() if v is not None)
 
@@ -867,7 +867,7 @@ def main():
             disk = _search_by_lun(disks_service, lun.get('id'))
         else:
             disk = disks_module.search_entity(search_params=searchable_attributes(module))
-            if vm_service and disk:
+            if vm_service and disk and state != 'attached':
                 # If the VM don't exist in VMs disks, but still it's found it means it was found
                 # for template with same name as VM, so we should force create the VM disk.
                 force_create = disk.id not in [a.disk.id for a in vm_service.disk_attachments_service().list() if a.disk]