ovirt_disk add warning for DiskAttachments params (#347)

* ovirt_disk add warning for DiskAttachments params * add changelogs * fix pep8 * fix flake8 * fix pep8
oVirt · Sep 20, 2021 · 35a60e6 · 35a60e6
1 parent 1278733
commit 35a60e6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/changelogs/fragments/347-ovirt_disk-add-warning-for-disk-attachemtns.yml b/changelogs/fragments/347-ovirt_disk-add-warning-for-disk-attachemtns.yml
@@ -0,0 +1,3 @@
+---
+minor_changes:
+  - ovirt_disk - Add warning for disk attachments (https://github.com/oVirt/ovirt-ansible-collection/pull/347).
diff --git a/plugins/modules/ovirt_disk.py b/plugins/modules/ovirt_disk.py
@@ -902,6 +902,13 @@ def main():
                     )
             elif state == 'detached':
                 ret = disk_attachments_module.remove()
+        elif any([
+                module.params.get('interface'),
+                module.params.get('activate'),
+                module.params.get('bootable'),
+                module.params.get('uses_scsi_reservation'),
+                module.params.get('pass_discard'), ]):
+            module.warn("Cannot use 'interface', 'activate', 'bootable', 'uses_scsi_reservation' or 'pass_discard' without specifing VM.")
 
         # When the host parameter is specified and the disk is not being
         # removed, refresh the information about the LUN.