-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding language ABAP #490 #821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The true color blue on a dark terminal is a little too low-contrast IMO, but the ANSI colors look good! The human eye can be weird -- sometimes something that mathematically is in the middle looks more dark or light -- but in this case the Euclidean distance is definitely closer to black, and I think it shows.
@o2sh I know this project was heavily inspired by neofetch, and AFAIK neofetch doesn't use any background colors, but do we want to implement backgrounds? A frequent issue is that some logos expect white for their negative space, and others black, and as a result the official colors sometimes only look good in a light theme or a dark theme. Otherwise contributors have to get creative with their color choices.
Also, many of our logos look better on dark themes than light. We typically prefer looking good on a dark terminal than a light one when we have to choose, right?
@spenserblack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good with both dark and light backgrounds now 👍
BTW @atluft you can use the Vercel preview deployment link if you want to look at what your additions/changes look like. |
Let's give our best for this one, this logo will be shown first when visiting onefetch.dev 😅 : Here is a suggestion based on you design @atluft :
|
Yes, dark backgrounds being the de facto standard on most terminals it makes sense to do it that way. Besides with #625 in place - while playing with vercel preview -, I don't think our logos look that bad on light backgrounds 🤔 |
@o2sh ❤️ that version of the logo! But just a heads up that that, since we don't convert true color I've always quietly considered |
Based on the SAP / ABAP logo: