Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code coverage of src/ui/mod.rs #1012

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Improve code coverage of src/ui/mod.rs #1012

merged 3 commits into from
Apr 10, 2023

Conversation

changhc
Copy link
Contributor

@changhc changhc commented Apr 10, 2023

Part of #700. The following lines should be covered by the new test cases:

image

Note that the test case num_to_color_code_match is almost meaningless. It's only for boosting test coverage a bit.

Result with tarpaulin:

|| Tested/Total Lines:
|| src/ui/mod.rs: 31/31
55.77% coverage, 681/1221 lines covered

src/ui/mod.rs Outdated Show resolved Hide resolved
src/ui/mod.rs Show resolved Hide resolved
Copy link
Owner

@o2sh o2sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @changhc, this is much appreciated!

I left a small remark

@o2sh o2sh merged commit 31b813f into o2sh:main Apr 10, 2023
@changhc changhc deleted the unit-test-ui branch April 10, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants