Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code coverage of src/info/mod.rs #1011

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Improve code coverage of src/info/mod.rs #1011

merged 2 commits into from
Apr 10, 2023

Conversation

changhc
Copy link
Contributor

@changhc changhc commented Apr 9, 2023

As part of #700. I checked the current code coverage and tried to cover these two methods:
image

@changhc changhc requested a review from o2sh as a code owner April 9, 2023 22:13
o2sh
o2sh approved these changes Apr 10, 2023
View reviewed changes
Copy link
Owner

@o2sh o2sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Thank a lot @changhc

@o2sh o2sh merged commit 050568f into o2sh:main Apr 10, 2023
@changhc changhc deleted the unit-test-info branch April 10, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o2sh o2sh o2sh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@changhc @o2sh