Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the 15-wires PLONK code #137

Merged
merged 74 commits into from
Oct 7, 2021
Merged

Conversation

mimoo
Copy link
Contributor

@mimoo mimoo commented Aug 27, 2021

This PR builds on #126 to introduce the 15-wires PLONK construction to the codebase.

In order of importance it:

  1. introduces a protocol change to always leave room for the zero knowledge polynomial
  2. fixes the generic gate
  3. fixes the poseidon gate (closes [15-wires] fix poseidon bug #136)
  4. adds a few of assertions
  5. adds a number of tests
  6. adds a number of (rustdoc) comments
  7. refactors some places to make the code cleaner
  8. merged master into this branch AND updated the code to use most recent arkworks
  9. ran cargo fmt

What's the minimum that needs to be done to merge this:

I propose that once this is cleaner/reviewed we merge it, and then work on a) more tests to make sure all gates work, etc. and b) OCaml bindings.

@mimoo mimoo requested review from mrmr1993, imeckler and jspada August 27, 2021 19:29
@mimoo mimoo mentioned this pull request Sep 28, 2021
9 tasks
@mimoo
Copy link
Contributor Author

mimoo commented Oct 5, 2021

merged master, and added small fix to CI

Copy link
Contributor

@imeckler imeckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@imeckler imeckler merged commit bfc067e into master Oct 7, 2021
@imeckler imeckler deleted the mimoo/15-wire-plonk-fixes-3 branch October 7, 2021 17:38
@spartucus
Copy link

Hi @mimoo, are there any papers or docs about kimchi?

@mimoo
Copy link
Contributor Author

mimoo commented Nov 23, 2021

there's https://o1-labs.github.io/mina-book/ but it's heavy work in progress

@spartucus
Copy link

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[15-wires] fix poseidon bug
5 participants