Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix createField with non-prime modulus #246

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Fix createField with non-prime modulus #246

merged 2 commits into from
Feb 16, 2024

Conversation

mitschabaude
Copy link
Collaborator

@mitschabaude mitschabaude commented Feb 16, 2024 •
edited
Loading

  • remove an assert in finite-field.ts that breaks foreign fields with non prime modulus
  • add exported constant that a recent PR missed

@mitschabaude mitschabaude merged commit 55a806a into main Feb 16, 2024
1 check passed
@mitschabaude mitschabaude deleted the fix/create-field branch February 16, 2024 09:12
@shimkiv shimkiv mentioned this pull request Feb 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trivo25 Trivo25 Trivo25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitschabaude @Trivo25