Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dtype inspection #4

Merged
merged 1 commit into from
May 26, 2020

Conversation

sjperkins
Copy link

No description provided.

@sjperkins
Copy link
Author

@o-smirnov This resolves the test case issues in holoviz#926 for me, locally.

@o-smirnov
Copy link
Owner

So do you want me to test this with shadems before you submit it to the main repo.

@sjperkins
Copy link
Author

This makes the datashader test suite pass locally for me.

I also ran:

$ shadems ~/data/AF0236_spw01.ms -x real -y imag 
$ shadems ~/data/AF0236_spw01.ms -x real -y imag -c FIELD_ID --count-cat

and they ran to completion, but I'm no expert in reading the tea leaves in the plot.

I wouldn't expect any breakage in the underlying functionality: the change exists to fix metadata handling. Maybe run it once on a test case you know well?

@sjperkins
Copy link
Author

So do you want me to test this with shadems before you submit it to the main repo.

I should have read this more carefully. Can you merge this into your treered-ds11 branch? I guess this will automatically update the PR and cause the datashader test suite to pass.

@sjperkins
Copy link
Author

It may be better for me to create the PR from my datashader fork as I'll be the one responding to their PR review comments.

@o-smirnov o-smirnov merged commit 6da009b into o-smirnov:treered-ds11 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants