Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the --lines option #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fabianscode
Copy link

tested with various options and scale

Copy link

@sid115 sid115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the number of lines is greater than the number of items, empty lines are added at the bottom of the menu. In my opinion, empty lines should be cut off like in the implementation of --lines in dmenu.

Also, in my opinion, it feels more natural to scroll through items in a vertical layout using the up and down arrow keys instead of left and right.

Other than that, everything works as expected.

Tested on NixOS 23.05 with an overlay using an edited dmenu-wayland's nix file to use this fork instead.

I am not familiar enough with C to contribute to this project, but I am happy to test changes and provide feedback if desired.

@fabianscode
Copy link
Author

Thanks for reviewing!
I agree with you on the arrow keys.
But since the original dmenu also does not implement dynamic height depending on the amount of non-empty lines, I suppose it would be better to simply make this functionality available through a patch.

@fabianscode
Copy link
Author

@nyyManni could you take a look at it, please? :)

@fabianscode
Copy link
Author

@sid115 arrow keys should be implemented now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants