Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct assertions in Interaction.respond #584

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

abitofevrything
Copy link
Member

Description

Some assertions didn't work when parameters weren't specified (or were set to null) and some assertions were duplicated. Also fixes ApplicationCommandInteraction.respond not setting _didRespond if not acknowledged.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@abitofevrything abitofevrything added the bug Something isn't working label Nov 6, 2023
@abitofevrything abitofevrything added this to the 6.0.2 milestone Nov 6, 2023
@abitofevrything abitofevrything self-assigned this Nov 6, 2023
@l7ssha l7ssha merged commit f7abb73 into dev Nov 6, 2023
@l7ssha l7ssha deleted the bug/interaction-response-assertions branch November 6, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants