Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pandas may fail to convert hifitime Epochs into datetime #154

Closed
ChristopherRabotin opened this issue May 25, 2023 · 1 comment
Closed

Pandas may fail to convert hifitime Epochs into datetime #154

ChristopherRabotin opened this issue May 25, 2023 · 1 comment
Labels
i-python Relative to the Python interface P-high
Milestone
Version 2.0.0-alp...

Comments

@ChristopherRabotin
Copy link
Member

Describe the bug

With some versions of pandas 2.0, the pd.to_datetime function in the plotting scripts may fail to convert the UTC epoch because pandas does not recognize UTC as a valid timezone. The fix is simple, but can't be done manually unless rewriting the plotting scripts.

To Reproduce

Steps to reproduce the behavior:

  1. Run the test_orbit_determination.py with the latest pandas
  2. Any of the plotting functions that uses to_datetime will fail.

Expected behavior

I expect the convert to work without failing

Code to reproduce the issue

The test above.

Platform

Linux

Additional context

N/A
@ChristopherRabotin ChristopherRabotin added Kind:Bug i-python Relative to the Python interface P-high labels May 25, 2023
@ChristopherRabotin
Copy link
Member Author

This would be fixed with nyx-space/hifitime#185.

ChristopherRabotin added a commit that referenced this issue May 25, 2023
@ChristopherRabotin
Merge pull request #155 from nyx-space/154-pandas-may-fail-to-convert…
c9e51e4 
…-hifitime-epochs-into-datetime

Fix #154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
i-python Relative to the Python interface P-high
Projects
None yet
Milestone
Version 2.0.0-alpha: Python binding a...
Development

No branches or pull requests
1 participant
@ChristopherRabotin