use correct starting angle for initial user pan check #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Veronique and @thiagopnts please review |
Veronique
reviewed
Jan 16, 2018
Sources/NYT360CameraController.m
Outdated
| @@ -10,6 +10,8 @@ | |||
| #import "NYT360EulerAngleCalculations.h" | |||
| #import "NYT360CameraPanGestureRecognizer.h" | |||
|
|
|||
| static const CGPoint kStartingPosition = { 3.14, 0 }; | |||
There was a problem hiding this comment.
Thanks for the fix.
Can you rename the constant variable to startingPosition or perhaps cameraStartingPosition? The k is very old school and in ObjectiveC constants typically start with a lower case letter.
|
LGTM 💯 |
Veronique
approved these changes
Jan 16, 2018
|
can one of you merge? I don't have permissions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our check for initial user pan was firing prematurely because we were using the wrong starting angle for comparison.