add service and a way to differentiate between gcloud groups and commands #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonglil
approved these changes
May 13, 2019
jprobinson
reviewed
May 13, 2019
|
fyi I don't think I have rights to merge this to master so if you 👍 someone with admin rights should do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the service field to be configurable on the gcloud command. It also splits the gcloud commands that respond to group or plain gcloud command because the syntax is different. I wasn't sure how I could write tests for this so any advice/suggestion welcome.
For example:
This is a group gcloud command:
gcloud app versions delete <service> <version>whereas this is a plain gcloud command:
gcloud app deploy <yml file> --version <version>The group type doesn't support deploying with a yml file.
Here are the gcloud docs for reference: https://cloud.google.com/sdk/gcloud/reference/app/