-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use scrolling UITextView for captions #88
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
0bdbe40
Add an example photo with extremely long caption
cdzombak b1319cd
Attach font sizes to captions in Example app
cdzombak 0fdaf3a
Use UITextView for NYTPhotoCaptionView
cdzombak 389b562
Reduce caption margins since UITextView has line fragment padding bui…
cdzombak 1e825d9
First pass at PhotoCaptionView intrinsic content size with a text view
cdzombak cefbcb3
Second pass at calculating caption content size
cdzombak 294848f
Give caption views a hint about their layout widths
cdzombak ee159d3
Extract NYTPhotoCaptionViewLayoutWidthHinting protocol to its own file
cdzombak 3070605
`pod install` in Example app
cdzombak a9e7aa5
Use relative, not hardcoded, max caption height
cdzombak bee2378
Add caption max height constraint from _our_ caption class
cdzombak 055ca60
Mark PhotoCaptionView as requiring constraint-based layout
cdzombak e7230df
PhotoCaptionView takes only 30% of height
cdzombak f88bad8
Resolve iOS 8.x gradient-layer layout bug
cdzombak f29731d
Eliminate added vertical padding on PhotoCaptionView
cdzombak 11b47eb
Merge remote-tracking branch 'origin/develop' into cdz/scroll-captions
cdzombak 81c1014
Standardize PhotoCaptionView.preferredMaxLayoutWidth on setting it
cdzombak 20eca18
Use textContainerInsets for padding PhotoCaptionView
cdzombak a5a5441
[minor] update forgotten header comments
cdzombak 7c59992
[minor] fix misspelled constant in PhotosViewController
cdzombak 162e0ba
Check for protocol conformance, not a specific method, before casting
cdzombak 4acbeeb
Use an enum for example photo indices
cdzombak 5d1a27d
Merge remote-tracking branch 'origin/develop' into cdz/scroll-captions
cdzombak 211d897
Resolve warning about unhandled case in Example project
cdzombak 0cd6a1e
Merge remote-tracking branch 'origin/develop' into cdz/scroll-captions
cdzombak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
Example/Pods/FLAnimatedImage/FLAnimatedImage/FLAnimatedImage.h
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again mostly curious, but this seems like a good place for a switch statement to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, especially if these were an enum.