Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creator id fix #1431

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Creator id fix #1431

merged 2 commits into from
Mar 8, 2024

Conversation

JeroenJRP
Copy link

Description

When the creator url is different from the identity url, the references to the creator entity would be wrong.
Truncated example:

{
      "@type": "WebSite",
      "author": {
        "@id": "https://example.com#identity"
      },
      "copyrightHolder": {
        "@id": "https://example.com#identity"
      },
      "creator": {
        "@id": "https://example.com#creator"
      },
      "publisher": {
        "@id": "https://example.com#creator"
      },
      "url": "https://example.com"
},
{
      "@id": "https://example.com#identity",
      "@type": "Organization",
      "name": "Example",
      "url": "https://example.com"
},
{
      "@id": "https://onstuimig.nl#creator",
      "@type": "Organization",
      "name": "Onstuimig",
      "url": "https://onstuimig.nl"
},

This PR makes sure all references to #creator use the creator url

@JeroenJRP JeroenJRP requested a review from khalwat as a code owner March 8, 2024 14:28
@khalwat
Copy link
Collaborator

khalwat commented Mar 8, 2024

Thank you for the PR, I will port it to the Craft 3 & Craft 5 versions of the plugin!

@khalwat khalwat merged commit 01d0a6d into nystudio107:develop-v4 Mar 8, 2024
2 checks passed
khalwat added a commit that referenced this pull request Mar 8, 2024
… wouldn't be correct if the `identity` and `creator` were not the same ([#1431](#1431))
khalwat added a commit that referenced this pull request Mar 8, 2024
… wouldn't be correct if the `identity` and `creator` were not the same ([#1431](#1431))
@JeroenJRP JeroenJRP deleted the creator-id-fix branch March 11, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants