-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First link of sitemap index is invisible and empty #1442
Comments
Edit |
I've been able to make my link reappeared, but I don't feel like it's truly fixed. My problematic section is "Pages" and we have a couple of different entry types. Some of them have the "sitemap enabled" setting toggled on and some of them have it off. |
How do you have the sitemap enabled toggled on or off via in some of these sections? Is it via SEOmatic -> Plugin Settings -> Content SEO or is it via an SEO Settings field? |
So there actually should be a separate sitemap for each entry type. Have you checked to see if there are multiple sitemaps for this section, one for each entry type? |
There's only one sitemap for the whole "Pages" section and not one for each entry type. |
Can you please provide me with a live URL to your sitemap index? |
This is the working one: However, all the page links starting with |
If you need a link with the broken sitemap, just let me know and I'll disable some entry types sitemap and invalidate our Cloudfront cache. |
I can take a look at it with you if you like; I feel like there may be something not quite right here. Book a time for a video conference: |
Perfect, I've booked a moment at beginning of next week. Thank you! 😄 |
Addressed in the above commits. You will need to re-save your Content SEO settings for each entry type. Craft CMS 3: You can try it now by setting your semver in your "nystudio107/craft-seomatic": "dev-develop as 3.4.75”, Then do a ….. Craft CMS 4: You can try it now by setting your semver in your "nystudio107/craft-seomatic": "dev-develop-v4 as 4.0.46”, Then do a ….. Craft CMS 5: You can try it now by setting your semver in your "nystudio107/craft-seomatic": "dev-develop-v5 as 5.0.0-beta.9”, Then do a |
It's hard for me to test. I've changed the plugin version to the one mentioned and followed your instructions and I still have my invisible link. I thought that I could try to disable and re-enable one of my pages entry type config, but I can't even access the sitemap menu of my entry type. It triggers an error. |
Sorry, fixed that just now, do these instructions again to update to the latest: Craft CMS 3: You can try it now by setting your semver in your "nystudio107/craft-seomatic": "dev-develop as 3.4.75”, Then do a ….. Craft CMS 4: You can try it now by setting your semver in your "nystudio107/craft-seomatic": "dev-develop-v4 as 4.0.46”, Then do a ….. Craft CMS 5: You can try it now by setting your semver in your "nystudio107/craft-seomatic": "dev-develop-v5 as 5.0.0”, Then do a |
|
Sorry for the late reply, but it seems like my bug is still present. I've tried with Seomatic version 4.0.46 and also with the newest 4.0.48 version. |
Did you re-save the Content SEO settings for each entry type? |
Yes I did. It worked on my local environment, but not on our QA environment. It's odd. I'm thinking that it might be related to one specific entry and not a type in general. I'm not sure though. |
I'm still seeing this issue as well, even after updating to v4.0.48 and re-saving the Content SEO settings for each entry type (and clearing all caches). |
@jwrudzin Are you working on the same project as @valboivin ? @valboivin Did you update the Content SEO settings on your QA environment for all entry types, as well as on your local environment? |
@khalwat, no we're not working on the same project. We don't even know each other. And yes, I've updated the SEO settings for all entry types on my local environment, QA environment and even Staging environment. |
And yet it is fixed locally, whereas it did not work before? I tested and verified the fix here, so I'm suspecting that it's something environmental. Are you able to inspect the They should be integer values, not strings. |
@khalwat For what it's worth I'm still seeing this issue both locally and on production. I resaved the content SEO settings and cleared all caches in both environments. Live non-working sitemap is here, in case it's helpful. I'll attach a screenshot of the database table you mentioned as well. |
@jwrudzin that link doesn't work -- I think you provided the link to the local dev site |
Yes, the |
@khalwat, I think I've found what is causing the bug! |
That raises another point, you can't have Sitemap Enabled toggled off at the Content SEO settings, and then attempt to selectively turn it back on again at the SEO Settings field level. It needs to work the other way around, where you keep Sitemap Enabled on for the Content SEO settings (because it is a higher level setting), and selectively disable it for some entries via the SEO Settings field. The Sitemap Enabled Content SEO setting is a higher-level setting that turns it off for that entire section. |
@valboivin That's pretty interesting. If you have time, I'd love to see the settings (either via screenshots here, or via a screen share again) that will allow me to replicate this locally. |
@khalwat I just launched another site that's running SEOmatic (v4.0.49), and am still running into this issue. Here is the link to the non-working sitemap on production. I'm seeing the issue on my local and staging sites as well. If there's any additional info I can provide to help troubleshoot, let me know! |
@jwrudzin Did you update the Content SEO settings for all entry types, as described above? |
@khalwat Interesting, toggling "Include Images & Videos in Sitemap" off and then back on seems to have fixed the issue. I think I'm all set. Thanks for the help! |
@jwrudzin right you need to resave the settings for that Content SEO section for the fix to work. |
@khalwat, just a heads up regarding this! We've upgraded to Craft 5 this week, and that bug with invisible/empty sitemap link reappeared! To fix it, once again, I add to toggle off and toggle back on the "Include Images & Videos in Sitemap" of our default page type config. I'm wondering if there's something worth investigating here. It is pretty odd. |
@valboivin very odd... is it possible an old db import was used in the upgrade process that didn't have the changes in it? |
@khalwat, not possible. We update our content almost everyday, so we couldn't use and old db import for the upgrade. Also, it was "fixed" on all our environments since end of April and we haven't touch Seomatic settings ever since. |
That's really odd, because nothing in those settings should be touched by the Craft 4 -> Craft 5 upgrade. |
Describe the bug
The sitemap index table indicates that there's one section, but the label and href are empty.
If I go directly to this section sitemap, I can see that it is well generated.
I've tried multiple times to regenerate the general sitemap with the same result.
Also, I've tested adding an additional individual URLs to the sitemap index. After this, I could see my original section sitemap link, but my additional URL was now in turn being invisible.
To reproduce
Steps to reproduce the behaviour:
Expected behaviour
The link to the section sitemap needs to visible and clickable.
Screenshots
Versions
The text was updated successfully, but these errors were encountered: