Remove old craft generated temp files #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I will roll this into the v3 version as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Craft temporary directory gets filled up with image files when ImageOptimize plugin is enabled.
After some debugging, it looks like Craft creates a copy of the image in the temp directory before firing off the
EVENT_TRANSFORM_IMAGEevent, and sends the path to the file as thetempPathproperty of the event object. Craft then pulls the path back out after any attached eventhandlers have done their thing, and finishes up any house cleaning tasks.The issue is that ImageOptimize creates its own file in the temp directory, and replaces the
tempPathproperty with the updated path. Craft then uses the path generated by the plugin for the rest of the process. The old temp file that was created by Craft is orphaned and fills up the temp directory.This PR is to make sure that the orphaned temp files get deleted so they don't stick around.