Only update variants for existing asset if the image has been manipulated #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when editing an existing asset, pressing Save triggers a call to
OptimizeImages::updateOptimizedImageFieldData()inline with the browser request—even if the editor only updated the title or a field value, and didn't manipulate the existing image at all. For assets that are configured to yield a lot of variants, this can cause the request to hang for quite a while and become a productivity bottleneck for the editor.This PR adds a check, to make sure an asset save was caused by an image manipulation, before firing the variant update process. It does this by checking that the current request is for the
assets/save-imageaction fired by theAssetImageEditor.