Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.x-dev] - Missing subfolder selections for image optimize field #333

Closed
twitcher07 opened this issue May 18, 2022 · 5 comments
Closed
Labels

Comments

@twitcher07
Copy link

twitcher07 commented May 18, 2022

Describe the bug

I created a volume in craft and added an image optimize field to it. However, going back and looking at the settings for the optimize field I do not see the option to select which subfolders to limit the creation of optimized images. Is this still a feature that will be carried over into Craft 4 version of the plugin?

Screenshots

image

Versions

  • Plugin version: v4.x-dev
  • Craft version: 4
@twitcher07 twitcher07 added the bug label May 18, 2022
@khalwat
Copy link
Contributor

khalwat commented May 18, 2022

Yep, it will be carried over. Changes in the way Craft 4 handles volumes/file systems have apparently broken this currently

@twitcher07
Copy link
Author

@khalwat ok awesome! I kind of assumed it was related to the asset changes for Craft 4.

Thank you to you and your team for developing such an awesome plugin!

@mihob
Copy link

mihob commented Jun 22, 2022

@khalwat Is there any news here? This is quite important feature for us, otherwise tons of unnecessary variations will be created.

@khalwat
Copy link
Contributor

khalwat commented Jun 23, 2022

I'm hoping to have it sorted out shortly. ImageOptimize for Craft 4 is next up on the list.

khalwat added a commit that referenced this issue Jun 27, 2022
@khalwat
Copy link
Contributor

khalwat commented Jun 27, 2022

Addressed in: 8233ec5

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-imageoptimize": "dev-develop-v4 as 4.0.0-beta.4”,

Then do a composer clear-cache && composer update

@khalwat khalwat closed this as completed Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants