Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio blocked event #83

Closed
wants to merge 2 commits into from
Closed

Audio blocked event #83

wants to merge 2 commits into from

Conversation

jkeen
Copy link
Contributor

@jkeen jkeen commented Apr 17, 2020

Started adding an audio-blocked event (#44)

Currently still having issues with HLS reporting audio blocked correctly. The way that connection is currently setup uses .play() to determine if it can even play, which causes problems because when the browser throws that error it stops the load entirely.

Added some rough tests to the diagnostic app -- add ?autoplay=http://url/to/m3u8 to try and autoplay a file on load.

@todo
Copy link

todo bot commented Apr 17, 2020

figure out a different way! Currently if we try to figure out if we're ready

// TODO: figure out a different way! Currently if we try to figure out if we're ready
// like this in an autoplay scenario and the browser blocks the request, the whole
// load process will stop
this.debug('Testing if audio is ready');
this.get('video').volume = 0;


This comment was generated by todo based on a TODO comment in c3c39e7 in #83. cc @nypublicradio.

@jkeen jkeen changed the title WIP: Audio blocked event Audio blocked event Apr 17, 2020
@jkeen
Copy link
Contributor Author

jkeen commented Nov 22, 2021

Resolved in ember-stereo

@jkeen jkeen closed this Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant