-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing blueprint and moving dependencies to npm #41
Conversation
baf1396
to
7c7d38c
Compare
This looks great, but I'd like for it to run on circle before we merge. I just updated our settings so that forks can run in our build system; would you mind adding a new commit and pushing again in order to kick off a build? I think an update to the readme to take out the generator command should do the trick ;) |
7c7d38c
to
19b1c90
Compare
I just realized that |
7c0d336
to
3157f72
Compare
I'm not sure what the |
So I think I've narrowed these failures down to an issue with yarn removing node-sass artifacts after some of the ember-try scenarios (yarnpkg/yarn#3506). I was able to reproduce locally, and it seems, from my limited testing, that this is fixed in yarn 0.27 (pre-release, atm). I'm not sure if it's possible to have circleci use a specific version of yarn. If not, I'd be happy to submit a PR that has circleci use npm (which doesn't face this issue) until circleci is updated. |
Oh boy. Thanks for tracking this down. For every problem yarn solves, it seems to introduce some new ones. Such is the way with technology tho. I'll see if I can update which yarn circle uses.
|
3157f72
to
0d49729
Compare
0d49729
to
70365c7
Compare
@@ -59,9 +59,13 @@ | |||
"web" | |||
], | |||
"dependencies": { | |||
"broccoli-funnel": "^1.2.0", | |||
"broccoli-merge-trees": "^1.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these go into devDependencies
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The consuming apps will need these to build the addon's vendor tree. If they're in devDependencies
, they won't be available to the app at build-time.
I added a command to our circle config that uses that yarn pre release and everything's looking green! One thing: I'm not 💯 on how let me know your thoughts on that question and I'll merge 'n' release. |
With ember-cli moving away from bower dependencies, thought it would be beneficial to move ember-hifi's dependencies over to npm.