Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _type field from index and delete commands #71

Merged
merged 1 commit into from
May 14, 2024

Conversation

rowanseymour
Copy link
Member

@ericnewcomer @norkans7 I've tested locally running this (with #70) on an existing index created with types and there doesn't seem to be any problem.

Removal of types within indexes (we don't use multi-type indexes) is the big breaking change between ES7/OS1 and ES8/OS2.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.96%. Comparing base (c4f3ec9) to head (9e8f40d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   50.96%   50.96%           
=======================================
  Files           6        6           
  Lines         569      569           
=======================================
  Hits          290      290           
  Misses        254      254           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkans7
Copy link
Contributor

@rowanseymour we need to update mailroom about that as well

@rowanseymour
Copy link
Member Author

@norkans7 just checked and the search commands we issue from mailroom don't use _type - the client library has a Type(string) method but it even mentions that this is deprecated and we don't use it.

@rowanseymour rowanseymour merged commit 6250bd9 into main May 14, 2024
7 checks passed
@rowanseymour rowanseymour deleted the cmds_without_type branch May 14, 2024 15:58
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants