Track history of flow ids on contacts #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #39 +/- ##
=======================================
Coverage 74.65% 74.65%
=======================================
Files 3 3
Lines 217 217
=======================================
Hits 162 162
Misses 33 33
Partials 22 22
Continue to review full report at Codecov.
|
rowanseymour
commented
Mar 22, 2022
contacts/index_settings.json
Outdated
| @@ -153,6 +153,12 @@ | |||
| "flow": { | |||
| "type": "keyword" | |||
| }, | |||
| "flow_id": { | |||
| "type": "integer" | |||
| }, | |||
There was a problem hiding this comment.
seems preferable to index a list of integers rather than UUIDs... and if we have to know about flow ids, why not switch flow over to being id based as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.