changes for elastic v7 #32
Conversation
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=======================================
Coverage 76.43% 76.43%
=======================================
Files 1 1
Lines 191 191
=======================================
Hits 146 146
Misses 25 25
Partials 20 20
Continue to review full report at Codecov.
|
| @@ -84,7 +84,7 @@ func CreateNewIndex(url string, alias string) (string, error) { | |||
| } | |||
|
|
|||
| // initialize our index | |||
| createURL := fmt.Sprintf("%s/%s", url, physicalIndex) | |||
| createURL := fmt.Sprintf("%s/%s?include_type_name=true", url, physicalIndex) | |||
There was a problem hiding this comment.
Needed for mapping to be supported.
|
|
||
| // deletes a contact | ||
| const deleteCommand = `{ "delete" : { "_id": %d, "_type": "_doc", "_version": %d, "_version_type": "external", "_routing": %d} }` | ||
| const deleteCommand = `{ "delete" : { "_id": %d, "_type": "_doc", "version": %d, "version_type": "external", "routing": %d} }` |
There was a problem hiding this comment.
Same parameters, just no underscores anymore.
| Hits []struct { | ||
| Total struct { | ||
| Value int `json:"value"` | ||
| } `json:"total"` |
There was a problem hiding this comment.
Now an object, this will have repercussions on how we query on the mailroom side.
| @@ -1,5 +1,10 @@ | |||
| cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw= | |||
There was a problem hiding this comment.
looks like a little go mod tidy wouldn't go amiss
There was a problem hiding this comment.
Thought the same, but no, these are all still there afterwards.
|
fixes #24 |
Mostly just updating the library we are dependent on and tweaking a few parameters. For 8.0 we'll have to address the mapping issue.