Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include rollups in monthlies failed metric #74

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

rowanseymour
Copy link
Member

Currently only include failures in monthlies created from scratch

@rowanseymour rowanseymour force-pushed the report_failed_rollups branch from 065cffa to 3f4b674 Compare July 8, 2022 10:34
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #74 (3f4b674) into main (26c2000) will increase coverage by 0.21%.
The diff coverage is 75.86%.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   70.67%   70.88%   +0.21%     
==========================================
  Files           6        6              
  Lines         832      845      +13     
==========================================
+ Hits          588      599      +11     
- Misses        139      141       +2     
  Partials      105      105              
Impacted Files Coverage Δ
archives/archives.go 73.10% <72.72%> (+0.13%) ⬆️
archives/utils.go 75.00% <77.77%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26c2000...3f4b674. Read the comment docs.

@rowanseymour rowanseymour merged commit 9add721 into main Jul 8, 2022
@rowanseymour rowanseymour deleted the report_failed_rollups branch July 8, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant