Analytics fix and additions and tests #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Jun 29, 2022
| @@ -323,7 +324,7 @@ func BuildRollupArchive(ctx context.Context, db *sqlx.DB, conf *Config, s3Client | |||
| ctx, cancel := context.WithTimeout(ctx, time.Hour) | |||
| defer cancel() | |||
|
|
|||
| start := time.Now() | |||
| start := dates.Now() | |||
There was a problem hiding this comment.
so can be mocked in test
rowanseymour
commented
Jun 29, 2022
| @@ -946,8 +947,11 @@ func ArchiveActiveOrgs(db *sqlx.DB, cfg *Config, s3Client s3iface.S3API) error { | |||
| return errors.Wrap(err, "error getting active orgs") | |||
| } | |||
|
|
|||
| totalRunsArchived, totalMsgsArchived := 0, 0 | |||
| totalRunsFailedArchives, totalMsgsFailedArchives := 0, 0 | |||
There was a problem hiding this comment.
forgot to actually increment these below
rowanseymour
force-pushed
the
better_stats
branch
from
7cef8f0 to
646148e
Compare
rowanseymour
force-pushed
the
better_stats
branch
from
646148e to
ab69184
Compare
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 67.11% 70.67% +3.55%
==========================================
Files 6 6
Lines 815 832 +17
==========================================
+ Hits 547 588 +41
+ Misses 166 139 -27
- Partials 102 105 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.