Better stats #70
Merged
Better stats #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
force-pushed
the
better_stats
branch
from
2bd7c0b to
906eeed
Compare
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 66.99% 67.11% +0.12%
==========================================
Files 6 6
Lines 815 815
==========================================
+ Hits 546 547 +1
- Misses 165 166 +1
+ Partials 104 102 -2
Continue to review full report at Codecov.
|
rowanseymour
commented
Jun 28, 2022
| @@ -758,23 +751,27 @@ func createArchive(ctx context.Context, db *sqlx.DB, config *Config, s3Client s3 | |||
| return nil | |||
| } | |||
|
|
|||
| func createArchives(ctx context.Context, db *sqlx.DB, config *Config, s3Client s3iface.S3API, org Org, archives []*Archive) error { | |||
There was a problem hiding this comment.
this method can't actually error
rowanseymour
commented
Jun 28, 2022
| if err != nil { | ||
| log.WithError(err).WithField("archive_type", MessageType).Error("error archiving org messages") | ||
| } | ||
| totalMsgsArchived += countRecords(created) |
There was a problem hiding this comment.
because dailies and monthlies are combined here, this double counts records archived
rowanseymour
commented
Jun 28, 2022
| assert.Equal(t, int64(23), created[62].Size) | ||
| assert.Equal(t, "f0d79988b7772c003d04a28bd7417a62", created[62].Hash) | ||
|
|
||
| // no rollup for october since that had one invalid daily archive |
There was a problem hiding this comment.
despite what this comment claims, the test data doesn't have any failing messages
norkans7
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the number of archives that we fail to create, don't over report records archived