cleanup archive file if there is a problem while uploading to s3 or writing to DB #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 68.21% 67.96% -0.26%
==========================================
Files 3 3
Lines 840 849 +9
==========================================
+ Hits 573 577 +4
- Misses 154 156 +2
- Partials 113 116 +3
Continue to review full report at Codecov.
|
rowanseymour
approved these changes
Nov 6, 2020
norkans7
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll leak files in the case of an error writing to S3 or writing the archive attributes to the DB. Defer should fix that.