-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for Configurable Archive Period #39
Conversation
Ok, added tests for ArchiveLength |
We're gonna run this on our side first, but I'd love some eyes on the changes I made to see if anything is wrong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot we had thought about making that an org level item one day, so that was easy!
Do let us know how it works out.
so far, so good. It seems to be handling in-use objects gracefully |
Ok it completed all its runs and it worked exactly as expected. We used a period of 30 days and it worked fine. |
Just an update- still working fine as expected |
Great, thanks, we'll merge in. |
Actually just realized that maybe |
I agree with that. |
For #38. Adds a config item called
ArchiveLength
that defaults to 90 days.Tests are updated, but still need to add tests specifically for changing the period