delete broadcasts which no longer have any active messages #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=========================================
- Coverage 69.07% 68.18% -0.9%
=========================================
Files 3 3
Lines 886 946 +60
=========================================
+ Hits 612 645 +33
- Misses 165 181 +16
- Partials 109 120 +11
Continue to review full report at Codecov.
|
rowanseymour
approved these changes
Apr 30, 2019
|
|
||
| // make sure we have no active messages | ||
| var msgCount int64 | ||
| err = db.Get(&msgCount, `SELECT count(*) FROM msgs_msg WHERE broadcast_id = $1`, broadcastID) |
There was a problem hiding this comment.
maybe not so important but if you just want to know if any rows exist, don't need to full count
There was a problem hiding this comment.
Ya, felt the error message was more interesting with count. In theory we should never really get to this case anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.