🚑 Replace final contact index still using is_test #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Feb 14, 2019
| @@ -30,7 +30,7 @@ CREATE INDEX IF NOT EXISTS channels_channelsession_pending_events | |||
|
|
|||
| CREATE INDEX IF NOT EXISTS contact_fields_keys_idx ON contacts_contact USING GIN(extract_jsonb_keys(fields)); | |||
|
|
|||
| CREATE INDEX IF NOT EXISTS contacts_contact_modified_on_non_test ON contacts_contact(modified_on) WHERE is_test = FALSE; | |||
| CREATE INDEX CONCURRENTLY contacts_contact_modified_on ON contacts_contact(modified_on); | |||
There was a problem hiding this comment.
anyone know what this index is used for? ES?
Codecov Report
@@ Coverage Diff @@
## master #2319 +/- ##
======================================
Coverage 100% 100%
======================================
Files 220 220
Lines 26139 26139
======================================
Hits 26139 26139Continue to review full report at Codecov.
|
rowanseymour
added a commit
to nyaruka/rp-indexer
that referenced
this pull request
Feb 15, 2019
Should only be deployed once nyaruka/rapidpro#2319 is deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how I managed to miss this one in #2314