better isort defaults, rerun, reblacked #1923
Conversation
setup.cfg
Outdated
| force_grid_wrap = 0 | ||
| line_length = 119 | ||
| combine_as_imports = True | ||
| sections = FUTURE,STDLIB,THIRDPARTY,DJANGO,DJANGOTHIRDPARTY,FIRSTPARTY,LOCALFOLDER |
There was a problem hiding this comment.
not sure I'd bother splitting third party into THIRDPARTY,DJANGO,DJANGOTHIRDPARTY but no biggie
There was a problem hiding this comment.
Not sure it is actually being triggered anywhere
There was a problem hiding this comment.
all the files I'm seeing now have django.* imports in their own section
There was a problem hiding this comment.
Oh thought you were talking third party django vs django. I for one like having Django being in their own thing.
This is why we shouldn't have options!
|
Found that with |
| combine_as_imports = True | ||
| sections = FUTURE,STDLIB,THIRDPARTY,DJANGO,DJANGOTHIRDPARTY,FIRSTPARTY,LOCALFOLDER | ||
| known_django = django | ||
| known_djangothirdparty = celery, leaflet |
There was a problem hiding this comment.
I think smartmin, DRF, django-countries should also belong in the django third party
Trailing comma in black is the only difference now, could be worth doing this until a new version of black comes out:
psf/black#250