Use more slog, replacing logrus #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
==========================================
- Coverage 62.56% 62.55% -0.02%
==========================================
Files 147 147
Lines 12324 12317 -7
==========================================
- Hits 7711 7705 -6
+ Misses 3779 3778 -1
Partials 834 834
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rowanseymour
reviewed
Oct 6, 2023
services/ivr/twiml/service.go
Outdated
| @@ -14,6 +14,8 @@ import ( | |||
| "strconv" | |||
| "strings" | |||
|
|
|||
| "log/slog" | |||
There was a problem hiding this comment.
put with other std lib deps
rowanseymour
reviewed
Oct 6, 2023
services/ivr/vonage/service.go
Outdated
| @@ -18,6 +18,8 @@ import ( | |||
| "strings" | |||
| "time" | |||
|
|
|||
| "log/slog" | |||
rowanseymour
reviewed
Oct 6, 2023
web/middleware.go
Outdated
| @@ -47,7 +42,7 @@ func panicRecovery(next http.Handler) http.Handler { | |||
| defer func() { | |||
| if rvr := recover(); rvr != nil { | |||
| debug.PrintStack() | |||
| log.WithError(errors.New(fmt.Sprint(rvr))).Error("recovered from panic in web handling") | |||
| slog.Error("recovered from panic in web handling", "error", errors.New(fmt.Sprint(rvr))) | |||
There was a problem hiding this comment.
I don't think errors.New(..) is needed here since it's just going to log as a string...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.