Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special handling deployment=test in cloudwatch service #150

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

rowanseymour
Copy link
Member

@rowanseymour rowanseymour commented Dec 13, 2024

Cuz unit tests shouldn't need to start and stop the queue stuff...

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.88%. Comparing base (dc71b8f) to head (4c2c887).

Files with missing lines Patch % Lines
aws/cwatch/service.go 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   89.14%   88.88%   -0.26%     
==========================================
  Files          51       51              
  Lines        2238     2241       +3     
==========================================
- Hits         1995     1992       -3     
- Misses        186      191       +5     
- Partials       57       58       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit fdb87f7 into main Dec 13, 2024
4 of 5 checks passed
@rowanseymour rowanseymour deleted the cloudwatch_test branch December 13, 2024 19:04
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants