Disambiguate simulator email i18n key #764
Conversation
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
=======================================
Coverage 64.19% 64.19%
=======================================
Files 164 164
Lines 6077 6077
Branches 1413 1413
=======================================
Hits 3901 3901
Misses 1746 1746
Partials 430 430
Continue to review full report at Codecov.
|
src/config/i18n/defaults.json
Outdated
| @@ -286,6 +286,7 @@ | |||
| "to": "To" | |||
| }, | |||
| "sent_email_dialog": "Email Details", | |||
| "sent_email_summary": "Sent email to \"[[recipients]]\" with subject \"[[subject]]\"", | |||
There was a problem hiding this comment.
so the structure of this arbitrary? like how subject is nested under sent_email?
There was a problem hiding this comment.
Dot notation is used to nest things where appropriate. Sent email has the to and subject labels in different places so have those nested, since this is a single blurb, opted for a single un-nested key.
Alternative would be something like this which I don't hate:
sent_mail
summary
dialog
title
to
subject
|
Saw there were no translations yet, so reworked those keys a bit. |
Fixes: #761