Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't scroll canvas when dialog is open #754

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Don't scroll canvas when dialog is open #754

merged 1 commit into from
Nov 20, 2019

Conversation

ericnewcomer
Copy link
Member

Fixes: #746

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #754 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
+ Coverage    64.2%   64.21%   +<.01%     
==========================================
  Files         164      164              
  Lines        6074     6075       +1     
  Branches     1410     1411       +1     
==========================================
+ Hits         3900     3901       +1     
  Misses       1745     1745              
  Partials      429      429
Impacted Files Coverage Δ
src/components/flow/Flow.tsx 66.66% <100%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0219363...d4b7cdd. Read the comment docs.

@ericnewcomer ericnewcomer merged commit 7ebbf5f into master Nov 20, 2019
@ericnewcomer ericnewcomer deleted the fix_scroll branch November 20, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unintended scrolling
1 participant