Add twitter handle scheme back in #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericnewcomer
commented
Nov 19, 2019
| ); | ||
| const AddURNComp: React.SFC<AddURN> = ({ scheme, path }): JSX.Element => { | ||
| const schemeObject = getSchemeObject(scheme); | ||
| const schemeName = schemeObject ? schemeObject.name : scheme; |
There was a problem hiding this comment.
As a failsafe, fallback to the scheme as the name if we don't recognize it.
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
==========================================
- Coverage 64.14% 64.13% -0.01%
==========================================
Files 164 164
Lines 6071 6073 +2
Branches 1406 1407 +1
==========================================
+ Hits 3894 3895 +1
Misses 1750 1750
- Partials 427 428 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.