Tweak metric reporter so all errors are logged #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #820 +/- ##
==========================================
- Coverage 74.58% 74.56% -0.02%
==========================================
Files 112 112
Lines 13271 13275 +4
==========================================
+ Hits 9898 9899 +1
- Misses 2653 2655 +2
- Partials 720 721 +1 ☔ View full report in Codecov by Sentry. |
rowanseymour
commented
Dec 18, 2024
| @@ -63,16 +63,16 @@ func (s *Stats) ToMetrics() []types.MetricDatum { | |||
| metrics = append(metrics, s.IncomingIgnored.metrics("IncomingIgnored")...) | |||
|
|
|||
| for typ, d := range s.IncomingDuration { // convert to averages | |||
| avgTime := float64(d) / float64(s.IncomingRequests[typ]) | |||
| metrics = append(metrics, cwatch.Datum("IncomingDuration", avgTime/float64(time.Second), types.StandardUnitSeconds, cwatch.Dimension("ChannelType", string(typ)))) | |||
| avgTime := d / time.Duration(s.IncomingRequests[typ]) | |||
There was a problem hiding this comment.
d is a sum of nanosecond durations so no loss of accuracy here
norkans7
approved these changes
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.