Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chi library #758

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Update chi library #758

merged 1 commit into from
Jun 19, 2024

Conversation

rowanseymour
Copy link
Member

go-chi fixed a memory leak related to compression middleware recently but I noticed that it breaks endpoints that aren't setting content-type - the docs for the compression middleware they state that you have to set content-type. If you don't you get trailing garbage at the end of the response body.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.87%. Comparing base (081c101) to head (90aacbe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
+ Coverage   75.86%   75.87%   +0.01%     
==========================================
  Files         111      111              
  Lines       10387    10393       +6     
==========================================
+ Hits         7880     7886       +6     
  Misses       1788     1788              
  Partials      719      719              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit 8ad8bd1 into main Jun 19, 2024
7 checks passed
@rowanseymour rowanseymour deleted the update_chi branch June 19, 2024 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant