Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust WA template to be send if present even when we have attachments #757

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

norkans7
Copy link
Contributor

@norkans7 norkans7 commented Jun 17, 2024

The engine now include attachment for media templates so we use template when present

No change for legacy WA as that do not support other components except body

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 87.10692% with 41 lines in your changes missing coverage. Please review.

Project coverage is 75.86%. Comparing base (959457a) to head (29a169d).

Files Patch % Lines
handlers/meta/handlers.go 87.56% 13 Missing and 10 partials ⚠️
handlers/dialog360/handler.go 86.46% 11 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
- Coverage   75.91%   75.86%   -0.05%     
==========================================
  Files         111      111              
  Lines       10375    10387      +12     
==========================================
+ Hits         7876     7880       +4     
- Misses       1784     1788       +4     
- Partials      715      719       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit 921f39f into main Jun 17, 2024
6 of 7 checks passed
@rowanseymour rowanseymour deleted the fix-d3c-media-attach branch June 17, 2024 17:43
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants