Use split attachments for templates media attachment for consistency … #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
==========================================
+ Coverage 75.83% 75.89% +0.06%
==========================================
Files 111 111
Lines 10365 10368 +3
==========================================
+ Hits 7860 7869 +9
+ Misses 1786 1784 -2
+ Partials 719 715 -4 ☔ View full report in Codecov by Sentry. |
rowanseymour
reviewed
Jun 6, 2024
handlers/meta/whatsapp/templates.go
Outdated
| attType = strings.Split(attType, "/")[0] | ||
| if attType == "application" { | ||
| attType = "document" | ||
| } |
There was a problem hiding this comment.
I think this code is simpler to read if we let attType stay as "application".. because that is is the attachment type in our world, and use document in the WhatsApp payload
…with messages attachments
norkans7
force-pushed
the
split-template-attachments
branch
from
fcdf3a0 to
08e87fc
Compare
rowanseymour
approved these changes
Jun 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…with messages attachments