Update D* handlers to use new send #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #703 +/- ##
==========================================
+ Coverage 74.20% 74.29% +0.09%
==========================================
Files 98 98
Lines 12922 12890 -32
==========================================
- Hits 9589 9577 -12
+ Misses 2632 2611 -21
- Partials 701 702 +1 ☔ View full report in Codecov by Sentry. |
rowanseymour
requested changes
Feb 27, 2024
handlers/dialog360/handler.go
Outdated
| @@ -549,7 +533,7 @@ func (h *handler) SendLegacy(ctx context.Context, msg courier.MsgOut, clog *cour | |||
|
|
|||
| payload.Interactive = &interactive | |||
| } else { | |||
| return nil, fmt.Errorf("too many quick replies WAC supports only up to 10 quick replies") | |||
| return fmt.Errorf("too many quick replies WAC supports only up to 10 quick replies") | |||
There was a problem hiding this comment.
should just truncate to 10 and log channel log error like we've done in other WhatsApp channels
There was a problem hiding this comment.
Sure, I will add that here as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.