Adjust channel logs for Twilio #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
==========================================
+ Coverage 73.93% 74.14% +0.20%
==========================================
Files 98 98
Lines 13026 13052 +26
==========================================
+ Hits 9631 9677 +46
+ Misses 2704 2689 -15
+ Partials 691 686 -5 ☔ View full report in Codecov by Sentry. |
rowanseymour
requested changes
Feb 21, 2024
handlers/nexmo/handler.go
Outdated
| return courier.ErrResponseUnexpected | ||
| // https://developer.vonage.com/messaging/sms/guides/troubleshooting-sms | ||
| clog.Error(courier.ErrorExternal("send:"+nexmoStatus, sendErrorCodes[errCode])) | ||
| return courier.ErrFailedWithReason(fmt.Sprint(errCode), sendErrorCodes[errCode]) |
There was a problem hiding this comment.
we don't want to these both because the error will be converted to a channel log error
There was a problem hiding this comment.
the code here needs to be the way it was previously: "send:"+nexmoStatus to work with
handlers/nexmo/handler_test.go
Outdated
| ExpectedError: courier.ErrResponseUnexpected, | ||
|
|
||
| ExpectedError: courier.ErrFailedWithReason("10", "Too Many Existing Binds"), | ||
| ExpectedLogErrors: []*courier.ChannelError{courier.ErrorExternal("send:10", "Too Many Existing Binds")}, |
handlers/twiml/handlers.go
Outdated
| @@ -291,7 +291,7 @@ func (h *handler) Send(ctx context.Context, msg courier.MsgOut, res *courier.Sen | |||
| if errorCode == errorStopped { | |||
| return courier.ErrContactStopped | |||
| } | |||
| return courier.ErrResponseUnexpected | |||
| clog.Error(twilioError(errorCode)) | |||
There was a problem hiding this comment.
return courier.ErrWithReason(...)
norkans7
force-pushed
the
twilio-error
branch
from
f6440cb to
093d89d
Compare
rowanseymour
requested changes
Feb 21, 2024
handlers/nexmo/handler.go
Outdated
| return courier.ErrResponseUnexpected | ||
| // https://developer.vonage.com/messaging/sms/guides/troubleshooting-sms | ||
| clog.Error(courier.ErrorExternal("send:"+nexmoStatus, sendErrorCodes[errCode])) | ||
| return courier.ErrFailedWithReason(fmt.Sprint(errCode), sendErrorCodes[errCode]) |
There was a problem hiding this comment.
the code here needs to be the way it was previously: "send:"+nexmoStatus to work with
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.