Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure text are sent after audio attachments for WA channels #445

Merged
merged 2 commits into from
May 30, 2022

Conversation

norkans7
Copy link
Contributor

@norkans7 norkans7 commented May 30, 2022

Audio attachment can not be sent with a caption so we need to send the text after

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #445 (2909fd1) into main (f68b9e0) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   72.25%   72.30%   +0.05%     
==========================================
  Files          95       95              
  Lines       12539    12563      +24     
==========================================
+ Hits         9060     9084      +24     
  Misses       2851     2851              
  Partials      628      628              
Impacted Files Coverage Δ
handlers/whatsapp/whatsapp.go 79.50% <100.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f68b9e0...2909fd1. Read the comment docs.

@norkans7 norkans7 requested a review from rowanseymour May 30, 2022 14:01
@rowanseymour rowanseymour merged commit 3faf663 into main May 30, 2022
@rowanseymour rowanseymour deleted the fix-WA-audio-text branch May 30, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants