Cloud API WA #430
Cloud API WA #430
Conversation
Codecov Report
@@ Coverage Diff @@
## main #430 +/- ##
==========================================
+ Coverage 71.90% 72.66% +0.75%
==========================================
Files 95 95
Lines 8387 12661 +4274
==========================================
+ Hits 6031 9200 +3169
- Misses 1757 2832 +1075
- Partials 599 629 +30
Continue to review full report at Codecov.
|
handlers/facebookapp/facebookapp.go
Outdated
| func newHandler(channelType courier.ChannelType, name string, useUUIDRoutes bool) courier.ChannelHandler { | ||
| return &handler{handlers.NewBaseHandlerWithParams(channelType, name, useUUIDRoutes)} | ||
| } | ||
|
|
||
| func init() { | ||
| courier.RegisterHandler(newHandler("IG", "Instagram", false)) | ||
| courier.RegisterHandler(newHandler("FBA", "Facebook", false)) | ||
| courier.RegisterHandler(newHandler("CWA", "Cloud API WhatsApp", false)) |
There was a problem hiding this comment.
how about we call this WAC / WhatsApp Cloud in code so that lexically this channel type will appear with the existing WA.. and if I'm looking for a WhatsApp channel type, I'm probably going to start looking under W
handlers/facebookapp/facebookapp.go
Outdated
|
|
||
| channelAddress = payload.Entry[0].Changes[0].Value.Metadata.DisplayPhoneNumber | ||
| if channelAddress == "" { | ||
| return nil, fmt.Errorf("no channel adress found") |
| AWSSecretAccessKey: "", | ||
| FacebookApplicationSecret: "missing_facebook_app_secret", | ||
| FacebookWebhookSecret: "missing_facebook_webhook_secret", | ||
| WhatsappAdminSystemUserToken: "missing_whatsapp_admin_system_user_token", |
There was a problem hiding this comment.
can this be a little more succinct? WhatsappAdminToken? WhatsappSystemUserToken?
There was a problem hiding this comment.
There are 2 types of system users so I thought that is more precise
contains #429