Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling stops via status callbacks on Twilio #427

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Fix handling stops via status callbacks on Twilio #427

merged 1 commit into from
Mar 21, 2022

Conversation

rowanseymour
Copy link
Member

@rowanseymour rowanseymour commented Mar 21, 2022 •
edited
Loading

rowanseymour
rowanseymour commented Mar 21, 2022
View reviewed changes
handlers/twiml/twiml.go
// create a stop channel event
channelEvent := h.Backend().NewChannelEvent(channel, courier.StopContact, urns.URN(form.To))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ends up being just a phone number

@rowanseymour rowanseymour requested a review from norkans7 March 21, 2022 17:00
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #427 (6868a5c) into main (17f7da4) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   71.92%   71.90%   -0.02%     
==========================================
  Files          95       95              
  Lines        8385     8387       +2     
==========================================
  Hits         6031     6031              
- Misses       1756     1757       +1     
- Partials      598      599       +1
Impacted Files Coverage Δ
handlers/twiml/twiml.go 84.18% <85.71%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17f7da4...6868a5c. Read the comment docs.

@rowanseymour rowanseymour merged commit ab3af80 into main Mar 21, 2022
@rowanseymour rowanseymour deleted the twilio_stop_fix branch March 21, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericnewcomer ericnewcomer ericnewcomer approved these changes

@norkans7 norkans7 Awaiting requested review from norkans7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rowanseymour @ericnewcomer