-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IG unsent support #415
IG unsent support #415
Conversation
Codecov Report
@@ Coverage Diff @@
## main #415 +/- ##
=======================================
Coverage 71.89% 71.89%
=======================================
Files 95 95
Lines 8357 8370 +13
=======================================
+ Hits 6008 6018 +10
- Misses 1753 1755 +2
- Partials 596 597 +1
Continue to review full report at Codecov.
|
@@ -142,6 +142,7 @@ type moPayload struct { | |||
IsEcho bool `json:"is_echo"` | |||
MID string `json:"mid"` | |||
Text string `json:"text"` | |||
IsDeleted string `json:"is_deleted"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this definitely correct according to their docs? I notice above that is_echo
is an actual bool
? Can go unmarshalling convert "true"
to true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There they send a string as shown on the webhook events example
https://developers.facebook.com/docs/messenger-platform/instagram/features/webhook#webhook-events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that's some impressively messy API design on their part
msgs_msg.id = (SELECT m."id" FROM "msgs_msg" m INNER JOIN "channels_channel" c ON (m."channel_id" = c."id") WHERE (c."uuid" = $1 AND m."external_id" = $2 AND m."direction" = 'I')) | ||
RETURNING | ||
msgs_msg.id | ||
` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches the soft deletion by nyaruka/rapidpro#3681
No description provided.