Allow more active redis connections #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Jan 19, 2022
| MaxIdle: 4, // only keep up to this many idle | ||
| IdleTimeout: 240 * time.Second, // how long to wait before reaping a connection | ||
| Dial: func() (redis.Conn, error) { | ||
| conn, err := redis.Dial("tcp", fmt.Sprintf("%s", redisURL.Host)) |
There was a problem hiding this comment.
linter complains that it's already a string
Codecov Report
@@ Coverage Diff @@
## main #407 +/- ##
=======================================
Coverage 71.99% 71.99%
=======================================
Files 95 95
Lines 8294 8294
=======================================
Hits 5971 5971
Misses 1731 1731
Partials 592 592
Continue to review full report at Codecov.
|
rowanseymour
commented
Jan 19, 2022
| @@ -592,11 +592,11 @@ func (b *backend) Start() error { | |||
| // create our pool | |||
| redisPool := &redis.Pool{ | |||
| Wait: true, // makes callers wait for a connection | |||
| MaxActive: 8, // only open this many concurrent connections at once | |||
| MaxActive: 36, // only open this many concurrent connections at once | |||
There was a problem hiding this comment.
matches what we have in mailroom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.