Send db and redis stats to librato in backed heartbeat #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Jan 18, 2022
| @@ -753,10 +781,13 @@ type backend struct { | |||
| db *sqlx.DB | |||
| redisPool *redis.Pool | |||
| storage storage.Storage | |||
| awsCreds *credentials.Credentials | |||
|
|
|||
| popScript *redis.Script | |||
rowanseymour
commented
Jan 18, 2022
| @@ -438,10 +437,39 @@ func (b *backend) Heartbeat() error { | |||
| bulkSize += count | |||
| } | |||
|
|
|||
| // log our total | |||
| // get our DB and redis stats | |||
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 71.70% 71.99% +0.29%
==========================================
Files 95 95
Lines 8269 8294 +25
==========================================
+ Hits 5929 5971 +42
+ Misses 1752 1731 -21
- Partials 588 592 +4
Continue to review full report at Codecov.
|
rowanseymour
force-pushed
the
db_redis_stats
branch
from
cf5a3fa to
a23b58d
Compare
norkans7
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.